devnet: Fix devnet#2684
Conversation
|
2231524 to
bdd2e97
Compare
bdd2e97 to
709d769
Compare
Inphi
left a comment
There was a problem hiding this comment.
looks good. Though removing images that match a glob can be surprising to users that build custom images (myself included) with a matching glob. It would be better if we removed specific image names. But this is acceptable too.
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
## Summary This PR replicates the changes from alloy-rs/alloy#2684 for the OpExecutionPayload types, adding `into_block_raw()` methods to centralize block construction logic and eliminate code duplication. ## Changes - Added `into_block_raw()` method to `OpExecutionPayloadV4` that converts the payload to a block with raw transactions - Added `into_block_raw()` method to `OpExecutionPayload` enum that delegates to the appropriate variant - Added `into_block_with_sidecar_raw()` method to `OpExecutionPayload` for creating blocks with sidecar data - Refactored `try_into_block_with` and `try_into_block_with_sidecar_with` methods to use the new raw methods combined with `Block::try_map_transactions` ## Motivation The alloy PR #2684 introduced these methods to provide a cleaner API and reduce code duplication. By using `into_block_raw()` methods that return blocks with raw transaction bytes, we can then use `Block::try_map_transactions` to convert them to any transaction type, making the code more maintainable and flexible. ## Notes - The implementation properly handles the fact that upstream alloy types return `Result<Block<Bytes>, PayloadError>` from their `into_block_raw` methods - All existing validation logic for Optimism-specific requirements (empty L1 withdrawals, no blob transactions) is preserved - Tests pass and formatting has been applied
…s/op-alloy#570) ## Summary This PR replicates the changes from alloy-rs/alloy#2684 for the OpExecutionPayload types, adding `into_block_raw()` methods to centralize block construction logic and eliminate code duplication. ## Changes - Added `into_block_raw()` method to `OpExecutionPayloadV4` that converts the payload to a block with raw transactions - Added `into_block_raw()` method to `OpExecutionPayload` enum that delegates to the appropriate variant - Added `into_block_with_sidecar_raw()` method to `OpExecutionPayload` for creating blocks with sidecar data - Refactored `try_into_block_with` and `try_into_block_with_sidecar_with` methods to use the new raw methods combined with `Block::try_map_transactions` ## Motivation The alloy PR #2684 introduced these methods to provide a cleaner API and reduce code duplication. By using `into_block_raw()` methods that return blocks with raw transaction bytes, we can then use `Block::try_map_transactions` to convert them to any transaction type, making the code more maintainable and flexible. ## Notes - The implementation properly handles the fact that upstream alloy types return `Result<Block<Bytes>, PayloadError>` from their `into_block_raw` methods - All existing validation logic for Optimism-specific requirements (empty L1 withdrawals, no blob transactions) is preserved - Tests pass and formatting has been applied
No description provided.